don't associate a file with a different package that matches a prefix

Shopify · Mar 19, 2024 · ca7ae0d · ca7ae0d
1 parent f52fb63
commit ca7ae0d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/packwerk/package.rb b/lib/packwerk/package.rb
@@ -42,7 +42,7 @@ def dependency?(package)
     def package_path?(path)
       return true if root?
 
-      path.start_with?(@name)
+      path.start_with?(@name + "/")
     end
 
     sig { params(other: T.untyped).returns(T.nilable(Integer)) }

diff --git a/test/unit/packwerk/package_test.rb b/test/unit/packwerk/package_test.rb
@@ -22,6 +22,10 @@ class PackageTest < Minitest::Test
       assert_equal(true, root_package.package_path?("components/unknown"))
     end
 
+    test "#package_path? returns false for different path with matching prefix" do
+      assert_equal(false, @package.package_path?("components/timeline_ui/something.rb"))
+    end
+
     test "#<=> compares against name" do
       assert_equal(-1, @package <=> Package.new(name: "components/xyz", config: {}))
       assert_equal(0, @package <=> Package.new(name: "components/timeline", config: {}))