Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Haml support #373

Open
richardmarbach opened this issue Oct 10, 2023 · 3 comments
Open

[Feature Request] Haml support #373

richardmarbach opened this issue Oct 10, 2023 · 3 comments

Comments

@richardmarbach
Copy link

We have a codebase that uses Haml as the templating engine. It would be great if packwerk could analyse Haml files as well.

Is Haml support interesting for the project? If there's interest, I'd be willing to contribute the feature.

@gmcgibbon
Copy link
Member

gmcgibbon commented Oct 11, 2023

Haml support makes sense to me, but it seems like it might make sense as a separate extension gem. You'll have to make a new parser, and likely improve the API for doing this in the parser factory.

@alexevanczuk
Copy link
Contributor

There's a related PR to improve the API for extending parsers here: #243

@richardmarbach
Copy link
Author

richardmarbach commented Oct 17, 2023

I've prepared haml support as an extension: https://github.com/richardmarbach/packwerk-haml

It currently depends on the PR branch: #375. Once the parser interface is finalised, I can adjust the haml parser to match it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants