New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new DL] Segmented buttons should not have a gap #3243

Closed

alex-page opened this issue Sep 14, 2020 · 2 comments · Fixed by #3263

Assignees

Labels

Bug

Member

alex-page commented Sep 14, 2020

The reason they are shown differently in Figma today is because Figma doesn't do negative auto-layout spacing. Segmented buttons should look like this.

I think we can want to stop connecting allll the fields though.

So instead of this:

we would do something like this:

alex-page added the Bug label

alex-page mentioned this issue

[Filters] Fix spacing issues with filters button group #3238

Merged

6 tasks

alex-page added the high priority label

alex-page changed the title ~~Segmented buttons should not have a gap~~ [new DL] Segmented buttons should not have a gap

cherrychau commented Sep 15, 2020

Other examples could be found on the "Create shipping label" page.

Under package and weight

Custom forms modal

ashwinnarayanan2001 mentioned this issue

[ButtonGroup] Fix Segmented Button Gap Fix #3263

Merged

6 tasks

ashwinnarayanan2001 closed this as completed in #3263

ashwinnarayanan2001 self-assigned this

cherrychau commented Sep 30, 2020

Hey @alex-page , I checked today and saw that the issue still persists on the Create shipping label page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment