[v4] Use hooks in components where it's easy #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
added
the
🤖Skip Changelog
Use useI18n() hook instead of wrapping in withAppProvider for components are already functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Hooks! Hooks! Hooks!
Death to withAppProvider! Death to withAppProvider! Death to withAppProvider!
WHAT is this pull request doing?
Many of our components are already functions, but got wrapped with withAppProvider to provide translations. This PR changes them to use the
useI18nhook so we avoid the need for the withAppProvider HoC.Class components haven't been touched, so we're still using withAppProvider in plenty of places, but this targets the components where this change is easy to make.
How to 🎩
Check everything still gets translations