Skip to content

Conversation

@AndrewMusgrave
Copy link
Member

WHY are these changes introduced?

At some point, these mocks became redundant, lets strip away this extra code

@BPScott BPScott temporarily deployed to polaris-react-pr-1978 August 16, 2019 15:39 Inactive
});

afterEach(() => {
(document.activeElement as HTMLElement).blur();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we can remove this as well, how if we're expecting on the activeElement it's good practice.

@AndrewMusgrave AndrewMusgrave requested a review from BPScott August 16, 2019 15:45
@BPScott BPScott temporarily deployed to polaris-react-pr-1978 August 16, 2019 15:45 Inactive
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AndrewMusgrave AndrewMusgrave merged commit 9f142e9 into master Aug 16, 2019
@AndrewMusgrave AndrewMusgrave deleted the rm-unneeded-mocks branch August 16, 2019 16:55
@dleroux dleroux temporarily deployed to production September 3, 2019 14:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants