Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Add empty state component a11y docs #2244

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Conversation

sadiesaurus
Copy link
Contributor

WHY are these changes introduced?

Adds accessibility guidance for the empty state component, to appear in polaris-react docs and in the style guide.

WHAT is this pull request doing?

  • Adds accessibility documentation for the empty state component (web only)
  • Adds an entry to UNRELEASED.md

How to 🎩

  1. Check out master from polaris-styleguide to get the changes that support the accessibility section.
  2. In another Terminal tab or window, check out this branch from polaris-react and run the instructions for testing in a consuming project.
  3. In the polaris-styleguide tab, run dev up && dev start.
  4. View changes after examples and props:

Screenshots

Screenshot of the empty state web only accessibility section

FYI @dpersing ❤️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2019

No changes

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@dpersing dpersing self-requested a review October 4, 2019 20:27
Copy link
Contributor

@dpersing dpersing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Go ahead and squash and merge, @sadiesaurus !

@sadiesaurus sadiesaurus merged commit 5ab7d8f into master Oct 4, 2019
@sadiesaurus sadiesaurus deleted the empty-state-a11y-docs branch October 4, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants