Update typescript to 3.9 and enable skipLibCheck #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
馃煝 No significant changes to |
kaelig
approved these changes
May 13, 2020
UNRELEASED.md
Outdated
| ### Dependency upgrades | ||
|
|
||
| - Update TypeScript to 3.9.2 ([#2981](https://github.com/Shopify/polaris-react/pull/2981)) |
There was a problem hiding this comment.
Use past tense in change log entries
TS 3.9 offers a few speed improvements. Nothing huuuuuge, but it shaves 3 seconds of our build and type-check commands. Enabling skipLibCheck (as set by our parent TS configs) meanwhile saves an additional 10 seconds as we don't bother checking TS declaration files that we don't use. Recently TS's init scripts were updated so now this is set to true in newly creacted configs so I'm now more confident in following suit. On Master: type-check took ~38s, build took ~52s This commit: type-check took ~24.5s, build took ~37s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Keeping up to date. tyepscript 3.9 is hot off the presses. Speeding up builds
WHAT is this pull request doing?
TS 3.9 offers a few speed improvements. Nothing huuuuuge, but it shaves 3
seconds of our build and type-check commands.
Enabling skipLibCheck (as set by our parent TS configs) meanwhile saves
an additional 10 seconds as we don't bother checking TS declaration files
that we don't use. Recently TS's init scripts were updated so now this
is set to true in newly creacted configs so I'm now more confident in
following suit.
On master: type-check took ~38s, build took ~52s
This commit: type-check took ~24.5s, build took ~37s
TypeScript 3.9 Release blog: https://devblogs.microsoft.com/typescript/announcing-typescript-3-9/
PR where TypeScript changed the value of skipLibCheck in new projects to be true: microsoft/TypeScript#37808
More info on what skipLibCheck does: https://swatinem.de/blog/js-tooling/#explaining-skiplibcheck
How to 馃帺
Check build tests and type-check pass. Do a quick tophat in a consuming app.