Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pagination] Remove NDL fallbacks #3833

Merged
merged 6 commits into from Jan 14, 2021
Merged

Conversation

aveline
Copy link
Contributor

@aveline aveline commented Jan 13, 2021

WHY are these changes introduced?

Fixes https://github.com/Shopify/polaris-ux/issues/554

WHAT is this pull request doing?

Removes fallback references to newDesignLanguage in the Pagination component

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@aveline aveline added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Jan 13, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2021

🟢 This pull request modifies 5 files and might impact 2 other files.

Details:
All files potentially affected (total: 2)
🧩 src/components/Page/components/Header/Header.tsx (total: 1)

Files potentially affected (total: 1)

🧩 src/components/Page/components/Header/tests/Header.test.tsx (total: 0)

Files potentially affected (total: 0)

🎨 src/components/Pagination/Pagination.scss (total: 2)

Files potentially affected (total: 2)

🧩 src/components/Pagination/Pagination.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/Pagination/tests/Pagination.test.tsx (total: 0)

Files potentially affected (total: 0)

@aveline
Copy link
Contributor Author

aveline commented Jan 13, 2021

I am wondering whether the interface PaginationProps can be removed altogether?

@aveline aveline marked this pull request as draft January 13, 2021 19:21
Copy link
Contributor

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed up a couple of small changes. I was going to try to explain how to remove the extend from the Pagination props but would have been too much writing and confusing I think 😄

@kyledurand kyledurand marked this pull request as ready for review January 13, 2021 22:18
@@ -1,187 +0,0 @@
@import '../../styles/common';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so awesome we can remove this entire file 🙌 🏄‍♂️ 🌌

Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @aveline 🔥 🔥 🔥

@aveline aveline merged commit b3fa7a4 into version-6.0.0 Jan 14, 2021
@aveline aveline deleted the pagination-remove-ndl branch January 14, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants