-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pagination] Remove NDL fallbacks #3833
Conversation
🟢 This pull request modifies 5 files and might impact 2 other files. Details:All files potentially affected (total: 2)🧩
|
I am wondering whether the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed up a couple of small changes. I was going to try to explain how to remove the extend from the Pagination props but would have been too much writing and confusing I think 😄
@@ -1,187 +0,0 @@ | |||
@import '../../styles/common'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so awesome we can remove this entire file 🙌 🏄♂️ 🌌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @aveline 🔥 🔥 🔥
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-ux/issues/554
WHAT is this pull request doing?
Removes fallback references to
newDesignLanguage
in the Pagination componentHow to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.md
with documentation changes