Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MediaCard] Fix the thumbnail’s corner roundness, so it won’t overflow out of the parent Card #3974

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

kaelig
Copy link
Contributor

@kaelig kaelig commented Feb 4, 2021

WHY are these changes introduced?

Fixes an issue in MediaCard where the thumbnail would overflow outside of the parent card on small screens at the top, as well as on larger screens, to the left, as in these screenshots:

Screen_Shot_2021-02-04_at_11_12_11_AM

Screen Shot 2021-02-04 at 11 31 10 AM

WHAT is this pull request doing?

Uses the new design language custom properties instead of the Sass functions when applying border radius values.

How to 🎩

Compare new and old versions on Chromatic, at various viewport sizes.

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2021

🟢 This pull request modifies 2 files and might impact 1 other files.

Details:
All files potentially affected (total: 1)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/MediaCard/MediaCard.scss (total: 1)

Files potentially affected (total: 1)

Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Amazing thanks Kaelig!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants