[IndexTable] Remove in your store from IndexTable bulk selection
#4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🟢 No significant changes to |
|
Does this actually improve the UX of the component? What if we removed Just trying to maintain simplicity in the code base and translations that we get locked into. |
|
@kyledurand this makes sense to me, double checking with the product person that asked me to make the change |
lhoffbeck
force-pushed
the
lh-adapt-index-table-to-take-parent-resource-name
branch
from
1cbc24a
to
092264a
Compare
lhoffbeck
changed the title
in your store from IndexTable bulk selection
This was referenced Mar 18, 2021
sylvhama
pushed a commit
that referenced
this pull request
Mar 26, 2021
…4013) * Remove parent resource name from select all items strings * fix test * Update locales/zh-TW.json * Update locales/ja.json * Update locales/zh-CN.json * Update locales/es.json * Update locales/nl.json * Update locales/fr.json * Update locales/ko.json * Update locales/cs.json * Update locales/pt-PT.json * Update locales/sv.json * Update locales/de.json * Update locales/it.json * Update locales/da.json * Update locales/pl.json * Update locales/tr.json * Update locales/vi.json * Update locales/nb.json * Update locales/fi.json * Update locales/pt-BR.json * Update locales/th.json Co-authored-by: translation-platform <35075727+translation-platform@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes shopify/web issue #38565
The IndexTable component assumes that the resource present in the list is a root-level resource, which means that the messaging when selecting all items in the list assumes that you're selecting all of that resource type across the entire store. This assumption may not always hold, which is what we're bumping up against in web.
WHAT is this pull request doing?
This PR removes the
in your storeassumption from theIndexTablebulk action strings.🎩 checklist
README.mdwith documentation changes