-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IndexTable] Remove in your store
from IndexTable bulk selection
#4013
[IndexTable] Remove in your store
from IndexTable bulk selection
#4013
Conversation
🟢 No significant changes to |
Does this actually improve the UX of the component? What if we removed Just trying to maintain simplicity in the code base and translations that we get locked into. |
@kyledurand this makes sense to me, double checking with the product person that asked me to make the change |
1cbc24a
to
092264a
Compare
in your store
from IndexTable bulk selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
…4013) * Remove parent resource name from select all items strings * fix test * Update locales/zh-TW.json * Update locales/ja.json * Update locales/zh-CN.json * Update locales/es.json * Update locales/nl.json * Update locales/fr.json * Update locales/ko.json * Update locales/cs.json * Update locales/pt-PT.json * Update locales/sv.json * Update locales/de.json * Update locales/it.json * Update locales/da.json * Update locales/pl.json * Update locales/tr.json * Update locales/vi.json * Update locales/nb.json * Update locales/fi.json * Update locales/pt-BR.json * Update locales/th.json Co-authored-by: translation-platform <35075727+translation-platform@users.noreply.github.com>
WHY are these changes introduced?
Fixes shopify/web issue #38565
The IndexTable component assumes that the resource present in the list is a root-level resource, which means that the messaging when selecting all items in the list assumes that you're selecting all of that resource type across the entire store. This assumption may not always hold, which is what we're bumping up against in web.
WHAT is this pull request doing?
This PR removes the
in your store
assumption from theIndexTable
bulk action strings.🎩 checklist
README.md
with documentation changes