Ensure @charset is at the top of generated css #4019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #4014
Our generated css file was not handling the consolidation and hoisting of
@charset
declarations.WHAT is this pull request doing?
Pulls the
@charset
declaration up to the top of the file. Will error if there is are multiple competing charsets though that shouldn't ever happen because prettier should force all our source files to be utf-8.How to 🎩
yarn run build
and checkdist/styles.css
and note that@charset "UTF-8";
is at the top of the file and not half way down.If you'd like to be more thorough compare output against main:
git checkout main && yarn clean && yarn build && mv dist dist-orig
git checkout fix-charset && yarn clean && yarn build
dist/styles.css
:diff -ru dist-orig dist