Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Page] only render actions wrapper in header component if actions are present #732

Merged
merged 1 commit into from
Dec 10, 2018
Merged

[Page] only render actions wrapper in header component if actions are present #732

merged 1 commit into from
Dec 10, 2018

Conversation

danrosenthal
Copy link
Contributor

Closes #731

@BPScott BPScott requested a deployment to polaris-react-pr-732 December 10, 2018 19:33 Abandoned
@BPScott BPScott requested a deployment to polaris-react-pr-732 December 10, 2018 19:34 Abandoned
@danrosenthal danrosenthal changed the title only render actions wrapper if there are actions in Page Header [Page] only render actions wrapper in header component if actions are present Dec 10, 2018
donnielrt
donnielrt approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@donnielrt donnielrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 thanks for the quick turnaround, Dan!

@danrosenthal danrosenthal merged commit e7fc151 into master Dec 10, 2018
@tmlayton tmlayton deleted the fix-page-extra-space branch December 10, 2018 20:08
@danrosenthal danrosenthal temporarily deployed to production December 12, 2018 18:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnielrt donnielrt donnielrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danrosenthal @donnielrt @BPScott