Move coverage into build/coverage

Move code coverage into an already ignored top level folder to avoid proliferation of top-level junk Simplify the logic for what reporters to use slightly
Shopify · Nov 2, 2018 · 1e2e00b · 1e2e00b
1 parent 04577dc
commit 1e2e00b
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 9 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -1,6 +1,5 @@
 node_modules
 /build
-/coverage
 /build-intermediate
 /build-esnext
 /docs

diff --git a/.gitignore b/.gitignore
@@ -4,7 +4,6 @@ node_modules
 /build-intermediate
 /build-esnext
 /docs
-/coverage
 /esnext
 /types
 /index.*

diff --git a/.prettierignore b/.prettierignore
@@ -1,6 +1,5 @@
 node_modules
 /build
-/coverage
 /build-intermediate
 /build-esnext
 /docs

diff --git a/.stylelintignore b/.stylelintignore
@@ -1,6 +1,5 @@
 node_modules
 /build
-/coverage
 /build-intermediate
 /build-esnext
 /docs

diff --git a/sewing-kit.config.ts b/sewing-kit.config.ts
@@ -35,11 +35,9 @@ export default function sewingKitConfig(
         };
 
         // Code coverage
-        config.coverageDirectory = 'coverage';
-        config.coverageReporters = ['text-summary', 'html'];
-        if (env.isCI) {
-          config.coverageReporters.push('lcov');
-        }
+        config.coverageDirectory = 'build/coverage';
+        config.coverageReporters = ['text-summary', 'html', 'lcovonly'];
+
         config.collectCoverageFrom = [
           'src/**/*.{ts,tsx}',
           '!src/test-utilities/**/*.*',