Skip to content

Commit

Permalink
[Resource Picker] change the default value of showHidden to true
Browse files Browse the repository at this point in the history
  • Loading branch information
hannachen committed Feb 11, 2019
1 parent 37fec6d commit 37524a5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions UNRELEASED.md
Expand Up @@ -20,6 +20,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

- Fixed the `DataTable` sort direction not reversing on second sort of the initially sorted column ([#918](https://github.com/Shopify/polaris-react/pull/918)) (thanks [@tabrez96](https://github.com/tabrez96) for the [issue report](https://github.com/Shopify/polaris-react/issues/873))
- Allow `null` being passed to `value` in `TextField` ([#964](https://github.com/Shopify/polaris-react/pull/964)) (thanks [@mbaumbach](https://github.com/mbaumbach) for the [original issue](https://github.com/Shopify/polaris-react/issues/959))
- Changed the default value for `showHidden` prop on `ResourcePicker` for backward compatibility with legacy EASDK ([#981](https://github.com/Shopify/polaris-react/pull/981))

### Documentation

Expand Down
4 changes: 2 additions & 2 deletions src/components/ResourcePicker/ResourcePicker.tsx
Expand Up @@ -20,7 +20,7 @@ export interface Props {
*/
initialQuery?: string;
/** Whether to show hidden products or not
* @default false
* @default true
*/
showHidden?: boolean;
/** Whether to allow selection of multiple items
Expand Down Expand Up @@ -54,7 +54,7 @@ export class ResourcePicker extends React.PureComponent<CombinedProps, never> {
open,
resourceType,
initialQuery,
showHidden = false,
showHidden = true,
allowMultiple = true,
showVariants = true,
onSelection,
Expand Down
Expand Up @@ -39,7 +39,7 @@ describe('<ResourcePicker />', () => {
resourceType: AppBridgeResourcePicker.ResourceType.Product,
options: {
initialQuery: undefined,
showHidden: false,
showHidden: true,
selectMultiple: true,
showVariants: true,
},
Expand Down

0 comments on commit 37524a5

Please sign in to comment.