[Button] Remove connectedDisclosure (#10182)

### WHY are these changes introduced? Fixes #10126  ### WHAT is this pull request doing? Removes all code related to connectedDisclosure Updates the split example to use Popover, ActionList, and ButtonGroup
Shopify · Aug 24, 2023 · e814c0e · e814c0e
1 parent b585808
commit e814c0e
Show file tree

Hide file tree

Showing 38 changed files with 113 additions and 457 deletions.
diff --git a/.changeset/honest-stingrays-act.md b/.changeset/honest-stingrays-act.md
@@ -0,0 +1,5 @@
+---
+'@shopify/polaris': major
+---
+
+Removed connectedDislosure prop on button
diff --git a/documentation/guides/migrating-from-v11-to-v12.md b/documentation/guides/migrating-from-v11-to-v12.md
@@ -53,4 +53,5 @@ Secondary, becomes oneThird:
 `npx @shopify/polaris-migrator react-rename-component <path> --renameFrom="HorizontalGrid" --renameTo="InlineGrid" --renamePropsFrom="HorizontalGridProps" --renamePropsTo="InlineGridProps"`
 
 **Button**
-// TODO
+
+- connectedDisclosure: [See the updated split example](https://polaris.shopify.com/components/actions/button)
diff --git a/polaris-react/locales/cs.json b/polaris-react/locales/cs.json
@@ -30,8 +30,7 @@
       "dismissButton": "Zavřít notifikaci"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Načítání",
-      "connectedDisclosureAccessibilityLabel": "Související akce"
+      "spinnerAccessibilityLabel": "Načítání"
     },
     "Common": {
       "checkbox": "zaškrtávací pole",

diff --git a/polaris-react/locales/da.json b/polaris-react/locales/da.json
@@ -30,8 +30,7 @@
       "dismissButton": "Afvis meddelelse"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Indlæser",
-      "connectedDisclosureAccessibilityLabel": "Relaterede handlinger"
+      "spinnerAccessibilityLabel": "Indlæser"
     },
     "Common": {
       "checkbox": "afkrydsningsfelt",

diff --git a/polaris-react/locales/de.json b/polaris-react/locales/de.json
@@ -30,8 +30,7 @@
       "dismissButton": "Benachrichtigung verwerfen"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Wird geladen",
-      "connectedDisclosureAccessibilityLabel": "Ähnliche Aktionen"
+      "spinnerAccessibilityLabel": "Wird geladen"
     },
     "Common": {
       "checkbox": "Kontrollkästchen",

diff --git a/polaris-react/locales/en.json b/polaris-react/locales/en.json
@@ -38,8 +38,7 @@
       "dismissButton": "Dismiss notification"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Loading",
-      "connectedDisclosureAccessibilityLabel": "Related actions"
+      "spinnerAccessibilityLabel": "Loading"
     },
     "Common": {
       "checkbox": "checkbox",

diff --git a/polaris-react/locales/es.json b/polaris-react/locales/es.json
@@ -30,8 +30,7 @@
       "dismissButton": "Descartar notificación"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Cargando",
-      "connectedDisclosureAccessibilityLabel": "Acciones relacionadas"
+      "spinnerAccessibilityLabel": "Cargando"
     },
     "Common": {
       "checkbox": "casilla de verificación",

diff --git a/polaris-react/locales/fi.json b/polaris-react/locales/fi.json
@@ -30,8 +30,7 @@
       "dismissButton": "Ohita ilmoitus"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Ladataan",
-      "connectedDisclosureAccessibilityLabel": "Aiheeseen liittyvät toimenpiteet"
+      "spinnerAccessibilityLabel": "Ladataan"
     },
     "Common": {
       "checkbox": "valintaruutu",

diff --git a/polaris-react/locales/fr.json b/polaris-react/locales/fr.json
@@ -30,8 +30,7 @@
       "dismissButton": "Rejeter la notification"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Chargement en cours",
-      "connectedDisclosureAccessibilityLabel": "Actions associées"
+      "spinnerAccessibilityLabel": "Chargement en cours"
     },
     "Common": {
       "checkbox": "case à cocher",

diff --git a/polaris-react/locales/it.json b/polaris-react/locales/it.json
@@ -30,8 +30,7 @@
       "dismissButton": "Elimina notifica"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Caricamento in corso",
-      "connectedDisclosureAccessibilityLabel": "Azioni correlate"
+      "spinnerAccessibilityLabel": "Caricamento in corso"
     },
     "Common": {
       "checkbox": "casella di spunta",

diff --git a/polaris-react/locales/ja.json b/polaris-react/locales/ja.json
@@ -30,8 +30,7 @@
       "dismissButton": "通知を閉じる"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "読み込み中",
-      "connectedDisclosureAccessibilityLabel": "関連したアクション"
+      "spinnerAccessibilityLabel": "読み込み中"
     },
     "Common": {
       "checkbox": "チェックボックス",

diff --git a/polaris-react/locales/ko.json b/polaris-react/locales/ko.json
@@ -30,8 +30,7 @@
       "dismissButton": "알림 무시"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "로드 중",
-      "connectedDisclosureAccessibilityLabel": "관련 작업"
+      "spinnerAccessibilityLabel": "로드 중"
     },
     "Common": {
       "checkbox": "확인란",

diff --git a/polaris-react/locales/nb.json b/polaris-react/locales/nb.json
@@ -30,8 +30,7 @@
       "dismissButton": "Avvis varsel"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Laster inn",
-      "connectedDisclosureAccessibilityLabel": "Relaterte handlinger"
+      "spinnerAccessibilityLabel": "Laster inn"
     },
     "Common": {
       "checkbox": "avmerkingsboks",

diff --git a/polaris-react/locales/nl.json b/polaris-react/locales/nl.json
@@ -30,8 +30,7 @@
       "dismissButton": "Melding sluiten"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Laden",
-      "connectedDisclosureAccessibilityLabel": "Gerelateerde acties"
+      "spinnerAccessibilityLabel": "Laden"
     },
     "Common": {
       "checkbox": "selectievakje",

diff --git a/polaris-react/locales/pl.json b/polaris-react/locales/pl.json
@@ -30,8 +30,7 @@
       "dismissButton": "Odrzuć powiadomienie"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Ładowanie",
-      "connectedDisclosureAccessibilityLabel": "Powiązane czynności"
+      "spinnerAccessibilityLabel": "Ładowanie"
     },
     "Common": {
       "checkbox": "pole wyboru",

diff --git a/polaris-react/locales/pt-BR.json b/polaris-react/locales/pt-BR.json
@@ -30,8 +30,7 @@
       "dismissButton": "Dispensar notificação"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Carregando",
-      "connectedDisclosureAccessibilityLabel": "Ações relacionadas"
+      "spinnerAccessibilityLabel": "Carregando"
     },
     "Common": {
       "checkbox": "caixa de seleção",

diff --git a/polaris-react/locales/pt-PT.json b/polaris-react/locales/pt-PT.json
@@ -30,8 +30,7 @@
       "dismissButton": "Ignorar notificação"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "A carregar",
-      "connectedDisclosureAccessibilityLabel": "Ações relacionadas"
+      "spinnerAccessibilityLabel": "A carregar"
     },
     "Common": {
       "checkbox": "caixa de verificação",

diff --git a/polaris-react/locales/sv.json b/polaris-react/locales/sv.json
@@ -30,8 +30,7 @@
       "dismissButton": "Avvisa avisering"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Laddar",
-      "connectedDisclosureAccessibilityLabel": "Relaterade åtgärder"
+      "spinnerAccessibilityLabel": "Laddar"
     },
     "Common": {
       "checkbox": "kryssruta",

diff --git a/polaris-react/locales/th.json b/polaris-react/locales/th.json
@@ -30,8 +30,7 @@
       "dismissButton": "ปิดการแจ้งเตือน"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "กำลังโหลด",
-      "connectedDisclosureAccessibilityLabel": "การดำเนินการที่เกี่ยวข้อง"
+      "spinnerAccessibilityLabel": "กำลังโหลด"
     },
     "Common": {
       "checkbox": "ช่องทำเครื่องหมาย",

diff --git a/polaris-react/locales/tr.json b/polaris-react/locales/tr.json
@@ -30,8 +30,7 @@
       "dismissButton": "Bildirimi kapat"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Yükleniyor",
-      "connectedDisclosureAccessibilityLabel": "İlgili işlemler"
+      "spinnerAccessibilityLabel": "Yükleniyor"
     },
     "Common": {
       "checkbox": "onay kutusu",

diff --git a/polaris-react/locales/vi.json b/polaris-react/locales/vi.json
@@ -30,8 +30,7 @@
       "dismissButton": "Bỏ qua thông báo"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "Đang tải",
-      "connectedDisclosureAccessibilityLabel": "Thao tác có liên quan"
+      "spinnerAccessibilityLabel": "Đang tải"
     },
     "Common": {
       "checkbox": "hộp kiểm",

diff --git a/polaris-react/locales/zh-CN.json b/polaris-react/locales/zh-CN.json
@@ -30,8 +30,7 @@
       "dismissButton": "忽略通知"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "正在加载",
-      "connectedDisclosureAccessibilityLabel": "相关操作"
+      "spinnerAccessibilityLabel": "正在加载"
     },
     "Common": {
       "checkbox": "复选框",

diff --git a/polaris-react/locales/zh-TW.json b/polaris-react/locales/zh-TW.json
@@ -30,8 +30,7 @@
       "dismissButton": "關閉通知"
     },
     "Button": {
-      "spinnerAccessibilityLabel": "載入中",
-      "connectedDisclosureAccessibilityLabel": "相關動作"
+      "spinnerAccessibilityLabel": "載入中"
     },
     "Common": {
       "checkbox": "核取方塊",

diff --git a/polaris-react/src/components/ActionMenu/components/SecondaryAction/SecondaryAction.scss b/polaris-react/src/components/ActionMenu/components/SecondaryAction/SecondaryAction.scss
@@ -48,7 +48,7 @@
     }
   }
 
-  &.destructive {
+  &.critical {
     a,
     button {
       color: var(--p-color-text-critical) !important;

diff --git a/polaris-react/src/components/ActionMenu/components/SecondaryAction/SecondaryAction.tsx b/polaris-react/src/components/ActionMenu/components/SecondaryAction/SecondaryAction.tsx
@@ -47,7 +47,7 @@ export function SecondaryAction({
     <div
       className={classNames(
         styles.SecondaryAction,
-        tone === 'critical' && styles.destructive,
+        tone === 'critical' && styles.critical,
       )}
       ref={secondaryActionsRef}
     >