-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid CSS syntax in latest builds #11784
Comments
Any update on this? |
This is still an issue on the last version |
### WHY are these changes introduced? Fixes #11784 ### WHAT is this pull request doing? Print css wasn't working here, the nesting was odd. To tophat go to render settings in dev tools and emulate print media in prod or storybook. ![image](https://github.com/Shopify/polaris/assets/6844391/3e1b0a53-5dc5-4d94-be83-151003856ae3) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
We just tried the
|
It wasn't included in 13.1.1 because that version needed to ship as a standalone revert. It will be included in the next version which you can follow along with here |
If you want to test the snapshot that was just created: If that works I can ship that as a patch today |
@kyledurand Thank you for the clarification. It works fine with |
Thanks all and sorry this took so long. Didn't see the issue til today. v13.1.2 should be out in < 5 mins and your builds should be 🟢 |
@kyledurand |
For anyone else that stumbles across this, I could use v12 by adjusting my webpack config. I was using the |
Summary
Since Polaris v12.22.0, our app builds fail due to invalid CSS syntax in this package.
This file: https://unpkg.com/@shopify/polaris@12.22.1/build/esm/styles.css
Contains this code:
Expected behavior
The media query should be something valid, like
@media print and (min-width: 10px)
.Actual behavior
The invalid media query breaks our CSS preprocessing (example).
Steps to reproduce
No response
Are you using React components?
None
Polaris version number
v12.22.1
Browser
No response
Device
No response
The text was updated successfully, but these errors were encountered: