[IndexTable] Shift click (multiselect) is broken #11809
Assignees
Comments
kyledurand
added a commit
that referenced
this issue
Apr 2, 2024
### WHY are these changes introduced? Fixes #11809 https://bugzilla.mozilla.org/show_bug.cgi?id=559506#:~:text=18%20days%20ago-,If%20you%20shift%2Bclick%20or%20ctrl%2Bclick%20on%20a%20label,checkbox%2C%20checkbox%20is%20not%20checked. ### WHAT is this pull request doing? This PR changes our checkbox input from being 1px / 1px hidden, to full size with opactiy 0. So the click event gets triggered. ### How to 🎩 [Spin](https://admin.web.checkbox.kyle-durand.us.spin.dev/store/shop1/orders) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our checkboxes are custom where the
labeldoes the actual work when click happens. Firefox doesn't allow the click event to bubble up on the label when shift is held downhttps://bugzilla.mozilla.org/show_bug.cgi?id=559506#:~:text=18%20days%20ago-,If%20you%20shift%2Bclick%20or%20ctrl%2Bclick%20on%20a%20label,checkbox%2C%20checkbox%20is%20not%20checked.
The text was updated successfully, but these errors were encountered: