Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge "progress" prop is not documented #172

Closed
sp4cecat opened this issue Aug 21, 2017 · 1 comment
Closed

Badge "progress" prop is not documented #172

sp4cecat opened this issue Aug 21, 2017 · 1 comment
Assignees
@danrosenthal

Comments

@sp4cecat
Copy link

Issue summary

There's an undocumented Parameter called "progress", not shown on the docs page

https://polaris.shopify.com/components/images-and-icons/badge#navigation

Expected behavior

Something like ..

progress enum Add a small circle in the badge displaying the completion status. [ 'incomplete' | 'partiallyComplete' | 'complete']

Actual behavior

Mysteriously absent from docs

Specifications

  • Polaris version: 1.3.1
  • React version: 15.6.1
  • Browser: Chrome
  • Device: Desktop
  • Operating System: Mac OS
@danrosenthal danrosenthal self-assigned this Aug 22, 2017
@dfmcphee
Copy link
Contributor

This is documented as part of 1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danrosenthal danrosenthal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dfmcphee @danrosenthal @sp4cecat