Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Consolidate se23 logic and styles #9972

Closed
Tracked by #9913
sophschneider opened this issue Aug 9, 2023 · 1 comment · Fixed by #10134
Closed
Tracked by #9913

[TextField] Consolidate se23 logic and styles #9972

sophschneider opened this issue Aug 9, 2023 · 1 comment · Fixed by #10134
Assignees
@gwyneplaine

Comments

@sophschneider
Copy link
Contributor

No description provided.

@sophschneider sophschneider mentioned this issue Aug 9, 2023
Closed
@gwyneplaine gwyneplaine self-assigned this Aug 17, 2023
@jesstelford
Copy link
Contributor

As part of this work, we should leverage the change made in #10081 to replace the hard-coded min-height with min-height: control-height():

polaris/polaris-react/src/components/TextField/TextField.scss

Line 199 in 23c1391

min-height: 32px;

See context in this comment: #10081 (review)

@gwyneplaine gwyneplaine mentioned this issue Aug 21, 2023
Merged
@gwyneplaine gwyneplaine linked a pull request Aug 21, 2023 that will close this issue
[TextField] consolidate se23 styles and logic #10134
Merged
gwyneplaine added a commit that referenced this issue Aug 22, 2023
@gwyneplaine
[TextField] consolidate se23 styles and logic (#10134)
210f212 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9972 


### WHAT is this pull request doing?

- `TextField` consolidate se23 logic
- `TextField` consolidate se23 styles


### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

-
[Storybook](https://5d559397bae39100201eedc1-ijxwodqxyd.chromatic.com/?path=/story/all-components-textfield--all)
- [Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-textfield--all&globals=polarisSummerEditions2023:true)
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@gwyneplaine @sophschneider
[TextField] consolidate se23 styles and logic (#10134)
96706f2 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9972 


### WHAT is this pull request doing?

- `TextField` consolidate se23 logic
- `TextField` consolidate se23 styles


### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

-
[Storybook](https://5d559397bae39100201eedc1-ijxwodqxyd.chromatic.com/?path=/story/all-components-textfield--all)
- [Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-textfield--all&globals=polarisSummerEditions2023:true)
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue Apr 22, 2024
@gwyneplaine
[TextField] consolidate se23 styles and logic (Shopify#10134)
fc9a2bf 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes Shopify#9972 


### WHAT is this pull request doing?

- `TextField` consolidate se23 logic
- `TextField` consolidate se23 styles


### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

-
[Storybook](https://5d559397bae39100201eedc1-ijxwodqxyd.chromatic.com/?path=/story/all-components-textfield--all)
- [Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-textfield--all&globals=polarisSummerEditions2023:true)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gwyneplaine gwyneplaine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TextField] consolidate se23 styles and logic Shopify/polaris
3 participants
@jesstelford @gwyneplaine @sophschneider