Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout.Section - replace booleans with new prop #9982

Closed
Tracked by #9914
kyledurand opened this issue Aug 9, 2023 · 0 comments
Closed
Tracked by #9914

Layout.Section - replace booleans with new prop #9982

kyledurand opened this issue Aug 9, 2023 · 0 comments
Assignees
@kyledurand
Labels
#gsd:36573 Polaris API Alignment

Comments

@kyledurand
Copy link
Contributor

No description provided.

@kyledurand kyledurand mentioned this issue Aug 9, 2023
Closed
@kyledurand kyledurand added v12 and removed untriaged labels Aug 11, 2023
@kyledurand kyledurand self-assigned this Aug 11, 2023
@kyledurand kyledurand mentioned this issue Aug 11, 2023
Merged
@sam-b-rose sam-b-rose added #gsd:36573 Polaris API Alignment and removed v12 labels Aug 15, 2023
kyledurand added a commit that referenced this issue Aug 17, 2023
@kyledurand
Add variant prop to Layout.Section (#10041)
8f927f7 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9982
<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Replaces boolean props on Layout.Section and replaces them with
`variant` prop

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩
kyledurand added a commit that referenced this issue Aug 17, 2023
@kyledurand
Add variant prop to Layout.Section (#10041)
6e5fff5 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9982
<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Replaces boolean props on Layout.Section and replaces them with
`variant` prop

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩
kyledurand added a commit that referenced this issue Aug 17, 2023
@kyledurand
Add variant prop to Layout.Section (#10041)
7975782 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9982
<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Replaces boolean props on Layout.Section and replaces them with
`variant` prop

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩
@sarahill sarahill mentioned this issue Sep 11, 2023
Closed
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@kyledurand @sophschneider
Add variant prop to Layout.Section (#10041)
d9c78ad 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9982
<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Replaces boolean props on Layout.Section and replaces them with
`variant` prop

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyledurand kyledurand

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyledurand @sam-b-rose