Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v12 #10060

Merged
merged 286 commits into from
Oct 9, 2023
Merged

v12 #10060

merged 286 commits into from
Oct 9, 2023

Conversation

sophschneider
Copy link
Contributor

@sophschneider sophschneider commented Aug 15, 2023 •
edited by gwyneplaine
Loading

Polaris v12

@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Aug 15, 2023
Closed
@sophschneider sophschneider mentioned this pull request Aug 15, 2023
Closed
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Aug 15, 2023
Closed
kyledurand and others added 7 commits August 17, 2023 17:46
@kyledurand
Remove banner experimental (#10112)
919895f 
Should get ci to 🟢
@kyledurand
Rename vertical stack to block stack (#10032)
cfb3054 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Part of #9984

Documentation improvement will be done in a follow up

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@gwyneplaine
[Select] consolidate se23 styles (#10081)
28f4165 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9963 

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

- Change control-height to be 32px
- `Select` consolidate se23 styles

### How to 🎩

*
[Storybook](https://5d559397bae39100201eedc1-oiuqenxfoy.chromatic.com/?path=/story/all-components-select--all)
* [Prod
storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-select--all)

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@kyledurand
Textfield add variant prop (#10036)
359614c 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10033

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Deprecates `borderless` prop in favor of `variant='borderless'`
@kyledurand
Add migration notes for layout components (#10115)
454bdd5 
### WHY are these changes introduced?

Part of #9984 #9985 #9983
@sophschneider
[Layout] Consolidate se23 logic and styles (#10093)
2bc5c45 
### WHY are these changes introduced?

Fixes #9943

### WHAT is this pull request doing?

 Consolidate se23 logic and styles for `Layout` Component

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-layout--all&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-afpqefhquh.chromatic.com/?path=/story/all-components-layout--annotated)
@sophschneider
[FormLayout] Consolidate se23 logic and styles (#10105)
f24db12 
### WHY are these changes introduced?

Fixes #9935

### WHAT is this pull request doing?

 Consolidate se23 logic and styles for `FormLayout` Component

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-formlayout--all&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-uozkfkbgfn.chromatic.com/?path=/story/all-components-formlayout--all)
@sophschneider sophschneider mentioned this pull request Aug 18, 2023
Merged
5 tasks
laurkim and others added 13 commits August 18, 2023 12:32
@laurkim
[Listbox] Consolidate se23 styles and logic (#10117)
88f6962 
### WHY are these changes introduced?

Resolves #9949 .

### WHAT is this pull request doing?

Consolidates se23 beta styles and logic for `Listbox`.

### How to 🎩

[Storybook](https://5d559397bae39100201eedc1-dojywcrcgy.chromatic.com/?path=/story/all-components-listbox--default)
[Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-listbox--default&globals=polarisSummerEditions2023:true)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@sophschneider
[DropZone] Consolidate se23 logic and styles (#10111)
10f8336 
### WHY are these changes introduced?

Fixes #9932

### WHAT is this pull request doing?

Consolidate se23 logic and styles for `DropZone` Component

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-dropzone--default&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-qvidvpjgoo.chromatic.com/?path=/story/all-components-dropzone--default)
@kyledurand
Rename HorizontalGrid to InlineGrid (#10116)
962d70a 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Part of #9985

<!--
  Context about the problem that’s being addressed.
-->
@gwyneplaine
[Link] consolidate se23 styles (#10113)
ea3223b 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9947 

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

- consolidate se23 styles

### How to 🎩

*
[Storybook](https://5d559397bae39100201eedc1-vcnbnkugpz.chromatic.com/?path=/story/all-components-link--default)
* [Prod
storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-link--default&globals=polarisSummerEditions2023:true)

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@laurkim
[List] Consolidate se23 styles (#10118)
cd9667f 
### WHY are these changes introduced?

Resolves #9948.

### WHAT is this pull request doing?

Consolidates se23 beta styles for `List`.

### How to 🎩

[Storybook](https://5d559397bae39100201eedc1-yvvnglksbe.chromatic.com/?path=/story/all-components-list--bulleted)
[Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-list--bulleted&globals=polarisSummerEditions2023:true)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@sophschneider
[DatePicker] Consolidate se23 logic and styles (#10120)
1ff9918 
### WHY are these changes introduced?

Fixes #9931

### WHAT is this pull request doing?

Consolidate se23 logic and styles for `DatePicker` Component
Add story delay for datepicker since the "All" test hasn't been
rendering in time on some PRs

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-datepicker--all&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-pxozkstezh.chromatic.com/?path=/story/all-components-datepicker--all)
@sophschneider
[MediaCard] Consolidate se23 logic and styles (#10124)
a0c1b72 
### WHY are these changes introduced?

Fixes #9950

### WHAT is this pull request doing?

Consolidate se23 logic and styles for `MediaCard` Component

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-mediacard--default&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-tugvkbzhsc.chromatic.com/?path=/story/all-components-mediacard--default)
@sophschneider
[Labelled] Consolidate se23 logic and styles (#10125)
1a35468 
### WHY are these changes introduced?

Fixes #9942

### WHAT is this pull request doing?

Consolidate se23 logic and styles for `Labelled` Component

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-textfield--with-help-text&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-spdehluzut.chromatic.com/?path=/story/all-components-textfield--with-help-text)
@sophschneider
[InlineError] Consolidate se23 logic and styles (#10127)
896dd5b 
### WHY are these changes introduced?

Fixes #9940

### WHAT is this pull request doing?

Consolidate se23 logic and styles for `InlineError` Component

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-inlineerror--default&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-aqogixplqr.chromatic.com/?path=/story/all-components-inlineerror--default)
@sophschneider
[PageActions] Consolidate se23 logic and styles (#10129)
7f64668 
### WHY are these changes introduced?

Fixes #9955

### WHAT is this pull request doing?

Consolidate se23 logic and styles for `PageActions` Component

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-pageactions--default&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-ddfrdxnifw.chromatic.com/?path=/story/all-components-pageactions--default)
@sophschneider
[ProgressBar] Consolidate se23 logic and styles (#10130)
3e8b30f 
### WHY are these changes introduced?

Fixes #9959

### WHAT is this pull request doing?

Consolidate se23 logic and styles for `PageActions` Component

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-progressbar--default&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-lasqorkejk.chromatic.com/?path=/story/all-components-progressbar--default)
@sophschneider
[SettingAction] Consolidate se23 logic and styles (#10131)
27422af 
### WHY are these changes introduced?

Fixes #9964

### WHAT is this pull request doing?

Consolidate se23 logic and styles for `SettingAction` Component

### How to 🎩
Compare production and this PR's chromatic storybook to make sure styles
are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-settingtoggle--with-deprecated-component&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-iqwftdxoka.chromatic.com/?path=/story/all-components-settingtoggle--with-deprecated-component)
@laurkim
[Modal] Consolidate se23 styles and logic (#10139)
310b34b 
### WHY are these changes introduced?

Resolves #9951.

### WHAT is this pull request doing?

Consolidates se23 beta styles and logic for `Modal`.

### How to 🎩

[Storybook](https://5d559397bae39100201eedc1-tqhardweqn.chromatic.com/?path=/story/all-components-modal--default)
[Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-modal--default&globals=polarisSummerEditions2023:true)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@Shopify Shopify deleted a comment from github-actions bot Oct 6, 2023
@Shopify Shopify deleted a comment from github-actions bot Oct 6, 2023
sophschneider and others added 2 commits October 6, 2023 10:11
@sophschneider
[polaris.shopify.com][Migration guide] Replace <path> with default gl…
e735554 
…ob path (#10913)

Having a `<path>` placeholder on the migration commands can get pretty
tedious to replace. I've added a default glob path so at least consumers
with a ts/tsx/css/scss architecture can copy and paste the commands out
of the box. I've also added a note that consumers can replace the
default glob path if they need to
@aveline
Uplift docs copy edits (#10905)
aac17f9
@sophschneider
Copy link
Contributor Author

/stageit

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

🚀 aac17f97b091941ee45f5dcccbbde50a41cfc828 is now deploying to staging. View status.

aaronccasanova and others added 6 commits October 6, 2023 08:37
@aaronccasanova @sarahill
Sort color tokens ascending (#10904)
12e1d90 
Co-authored-by: Sara Hill <sarashill22@gmail.com>
@aaronccasanova
Update migrating-from-v11-to-v12.md
85880d8
@sophschneider
Merge branch 'main' into next
099f304
@aaronccasanova
Revert "Revert "Executing useBreakpoints isormophically no longer t… (
aaf61fe 
#10918)

…riggers a Hydration mismatch error or rendering bugs." (#10916)"

This reverts #10916 to reapply
#10886

cc @jesstelford
@kyledurand
[polaris.shopify.com] Add aspect ratios on thumbnail preview (#10924)
de45d86 
### WHY are these changes introduced?

Fixes #10908

This PR adds the ability to be more specific about which aspect ratios
need to be applied to specific images but the issue was sparse so I
don't know of other places that need to be fixed. Let me know and I'll
update with screenshots

It also fixes a bg color mismatch between image bg and thumbnail bg
color

### WHAT is this pull request doing?

Before:

![image](https://github.com/Shopify/polaris/assets/6844391/fee88088-066c-4907-b3f5-af4d89dc3148)

After:

![specific-aspect-ratios](https://github.com/Shopify/polaris/assets/6844391/bb54e847-c554-4637-96b0-46acf9d69f9d)

![localhost_3000_design_colors
(1)](https://github.com/Shopify/polaris/assets/6844391/693283fe-b7c0-4ddb-b22c-3b139fb75a7d)

![localhost_3000_design_colors
(2)](https://github.com/Shopify/polaris/assets/6844391/81f4b922-26c5-4fb1-a399-d0e588e032f3)
@sophschneider
Migration guide updates
1fe291f
@gwyneplaine gwyneplaine marked this pull request as ready for review October 9, 2023 02:33
@gwyneplaine gwyneplaine requested review from a team as code owners October 9, 2023 02:33
@gwyneplaine
Copy link
Contributor

/stageit

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

🚀 1fe291f1d60a3d4a58027b01a3ccaffebad90f25 is now deploying to staging. View status.

gwyneplaine
gwyneplaine approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@gwyneplaine gwyneplaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jesstelford
jesstelford approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@jesstelford jesstelford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@gwyneplaine gwyneplaine changed the title Next v12 Oct 9, 2023
@gwyneplaine gwyneplaine merged commit 91abd25 into main Oct 9, 2023
15 of 16 checks passed
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Oct 9, 2023
Merged
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@gwyneplaine
v12 (Shopify#10060)
42870e6 
Polaris v12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@translation-platform translation-platform[bot] translation-platform left review comments

@jesstelford jesstelford jesstelford approved these changes

@gwyneplaine gwyneplaine gwyneplaine approved these changes

Assignees
No one assigned
Labels
cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. 🤖Skip Comment Check Skip the migrator comment CI check 🤖Skip Major Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet