[TooltipOverlay] Consolidate se23 styles and logic #10167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurkim
requested review from
jesstelford,
sam-b-rose,
gwyneplaine and
sophschneider
sophschneider
approved these changes
Aug 22, 2023
| $boxShadow: var(--p-shadow-md), | ||
| $borderRadius: var(--pc-tooltip-border-radius), | ||
| $zIndex: var(--pc-tooltip-shadow-bevel-z-index), | ||
| // The following arguments explicitly ignore the shadow-bevel opt out |
There was a problem hiding this comment.
I wonder if we can delete these now 馃 I added it as the last point to this epic so we can check across all the mixin uses at the end!
There was a problem hiding this comment.
Oh good point, removed those styles re: shadow-bevel opt out 馃檶
|
|
||
| @media screen and (-ms-high-contrast: active) { | ||
| border: var(--p-border-width-2) solid windowText; | ||
| } | ||
|
|
||
| &::after { | ||
| content: ''; | ||
| content: none; |
There was a problem hiding this comment.
could we just delete this whole &:after block now?
laurkim
force-pushed
the
lo/rm-uiplift-tooltip-overlay
branch
from
bad1720
to
777de22
Compare
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
### WHY are these changes introduced? Resolves #9974. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `TooltipOverlay`. Updates copy for keyboard nav tooltips in `Pagination` to match copy in admin. ### How to 馃帺 [Storybook](https://5d559397bae39100201eedc1-tewmslxdlb.chromatic.com/?path=/story/all-components-tooltip--all) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-tooltip--all&globals=polarisSummerEditions2023:true) [Pagination Storybook](https://5d559397bae39100201eedc1-tewmslxdlb.chromatic.com/?path=/story/all-components-pagination--with-keyboard-navigation) 馃枼 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 馃棐 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 馃搫 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 馃帺 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Resolves Shopify#9974. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `TooltipOverlay`. Updates copy for keyboard nav tooltips in `Pagination` to match copy in admin. ### How to 馃帺 [Storybook](https://5d559397bae39100201eedc1-tewmslxdlb.chromatic.com/?path=/story/all-components-tooltip--all) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-tooltip--all&globals=polarisSummerEditions2023:true) [Pagination Storybook](https://5d559397bae39100201eedc1-tewmslxdlb.chromatic.com/?path=/story/all-components-pagination--with-keyboard-navigation) 馃枼 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 馃棐 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 馃搫 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 馃帺 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #9974.
WHAT is this pull request doing?
Consolidates se23 beta styles and logic for
TooltipOverlay.Updates copy for keyboard nav tooltips in
Paginationto match copy in admin.How to 馃帺
Storybook
Prod Storybook
Pagination Storybook
馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines
馃帺 checklist
README.mdwith documentation changes