Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the rest of se23 scss styles #10239

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

sophschneider
Copy link
Contributor

@sophschneider sophschneider commented Aug 25, 2023

WHAT is this pull request doing?

  • Consolidates se23 styles in scss files that were either missed or added back in as part of bad rebases
  • Renames stylelint comments that include se23

How to 🎩

Tophatting links are in the file changes per component

cursor: default;
}

#{$se23} &:hover {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var(--p-color-border-interactive-focus);
outline-offset: var(--p-space-025);
background-color: var(--p-color-bg-input-hover-experimental);
border-width: 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Icon svg {
fill: var(--p-color-icon-disabled);
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sophschneider sophschneider added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Aug 25, 2023
@sophschneider sophschneider marked this pull request as ready for review August 25, 2023 18:19
Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 🚀

@sophschneider sophschneider merged commit b14efbb into next Aug 25, 2023
17 of 18 checks passed
@sophschneider sophschneider deleted the sophie/clean-up-rest-scss branch August 25, 2023 18:47
sophschneider added a commit that referenced this pull request Sep 19, 2023
### WHAT is this pull request doing?

* Consolidates `se23` styles in scss files that were either missed or
added back in as part of bad rebases
* Renames stylelint comments that include `se23`

### How to 🎩

Tophatting links are in the file changes per component
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
### WHAT is this pull request doing?

* Consolidates `se23` styles in scss files that were either missed or
added back in as part of bad rebases
* Renames stylelint comments that include `se23`

### How to 🎩

Tophatting links are in the file changes per component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants