[AppProvider] Disable calt font ligatures #10871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cla-needed
github-actions
bot
removed
the
cla-needed
sam-b-rose
approved these changes
Oct 4, 2023
|
/snapit |
chloerice
force-pushed
the
disable-calt-ligatures
branch
from
6035386
to
74b8c11
Compare
benwolfram
approved these changes
Oct 4, 2023
This was referenced Oct 4, 2023
Merged
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? The Inter font has several configurable font settings. By default, `calt` ligatures are not disabled. This causes unwanted change in the presentation of letters to be symbols, e.g., "x" appearing as a multiply symbol when between numbers like `7x8`. This is a problem for automated unique identifiers, like Hydrogen deploy hashes in the `/custom-storefronts` section of the admin: https://github.com/Shopify/polaris/assets/18447883/e8c4d2a1-9d22-42a7-a585-a158e9dcb1b5 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? This PR disables `calt` ligatures in the base styles of the `AppProvider`. | Before | After | |--------|--------| | <img width="239" alt="Screenshot 2023-10-04 at 2 25 05 PM" src="https://github.com/Shopify/polaris/assets/18447883/346bc486-866c-4d64-8fd2-1d13bcad8a0c">| <img width="237" alt="Screenshot 2023-10-04 at 2 24 50 PM" src="https://github.com/Shopify/polaris/assets/18447883/fc9f8cc4-d3bc-4d86-8ba4-dd466ed1f4ed"> | <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page, Text} from '../src'; export function Playground() { return ( <Page title="Discounts"> <Text as="p">xguxh880x9klaslojoffihghgthslohfijkl</Text> </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? The Inter font has several configurable font settings. By default, `calt` ligatures are not disabled. This causes unwanted change in the presentation of letters to be symbols, e.g., "x" appearing as a multiply symbol when between numbers like `7x8`. This is a problem for automated unique identifiers, like Hydrogen deploy hashes in the `/custom-storefronts` section of the admin: https://github.com/Shopify/polaris/assets/18447883/e8c4d2a1-9d22-42a7-a585-a158e9dcb1b5 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? This PR disables `calt` ligatures in the base styles of the `AppProvider`. | Before | After | |--------|--------| | <img width="239" alt="Screenshot 2023-10-04 at 2 25 05 PM" src="https://github.com/Shopify/polaris/assets/18447883/346bc486-866c-4d64-8fd2-1d13bcad8a0c">| <img width="237" alt="Screenshot 2023-10-04 at 2 24 50 PM" src="https://github.com/Shopify/polaris/assets/18447883/fc9f8cc4-d3bc-4d86-8ba4-dd466ed1f4ed"> | <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page, Text} from '../src'; export function Playground() { return ( <Page title="Discounts"> <Text as="p">xguxh880x9klaslojoffihghgthslohfijkl</Text> </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? The Inter font has several configurable font settings. By default, `calt` ligatures are not disabled. This causes unwanted change in the presentation of letters to be symbols, e.g., "x" appearing as a multiply symbol when between numbers like `7x8`. This is a problem for automated unique identifiers, like Hydrogen deploy hashes in the `/custom-storefronts` section of the admin: https://github.com/Shopify/polaris/assets/18447883/e8c4d2a1-9d22-42a7-a585-a158e9dcb1b5 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? This PR disables `calt` ligatures in the base styles of the `AppProvider`. | Before | After | |--------|--------| | <img width="239" alt="Screenshot 2023-10-04 at 2 25 05 PM" src="https://github.com/Shopify/polaris/assets/18447883/346bc486-866c-4d64-8fd2-1d13bcad8a0c">| <img width="237" alt="Screenshot 2023-10-04 at 2 24 50 PM" src="https://github.com/Shopify/polaris/assets/18447883/fc9f8cc4-d3bc-4d86-8ba4-dd466ed1f4ed"> | <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page, Text} from '../src'; export function Playground() { return ( <Page title="Discounts"> <Text as="p">xguxh880x9klaslojoffihghgthslohfijkl</Text> </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The Inter font has several configurable font settings. By default,
caltligatures are not disabled. This causes unwanted change in the presentation of letters to be symbols, e.g., "x" appearing as a multiply symbol when between numbers like7x8. This is a problem for automated unique identifiers, like Hydrogen deploy hashes in the/custom-storefrontssection of the admin:calt-ligatures-causing-x-beside-numbers-to-become-.mp4
WHAT is this pull request doing?
This PR disables
caltligatures in the base styles of theAppProvider.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes