Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove usage of useBreakpoints from <Banner> #10891

Closed

Conversation

jesstelford
Copy link
Contributor

@jesstelford jesstelford commented Oct 5, 2023

Depends on #10890

This PR removes all usages of useBreakpoints internally, allowing us to push the media query matching to CSS where it belongs for style props.

@jesstelford jesstelford force-pushed the responsive-props-not-use-breakpoint branch from 951333f to 0008cb6 Compare October 5, 2023 07:51
@jesstelford jesstelford force-pushed the responsive-props-not-use-breakpoint branch from 0008cb6 to e777305 Compare October 5, 2023 09:21
@jesstelford jesstelford force-pushed the responsive-props-not-use-breakpoint branch from e777305 to acb1bcc Compare October 5, 2023 09:59
@jesstelford jesstelford force-pushed the responsive-props-not-use-breakpoint branch from acb1bcc to 3cbf209 Compare October 6, 2023 06:03
@jesstelford jesstelford force-pushed the responsive-props-not-use-breakpoint branch 2 times, most recently from e274a87 to 551e9c5 Compare October 7, 2023 08:38
@jesstelford jesstelford force-pushed the responsive-props-not-use-breakpoint branch from 551e9c5 to 68a3864 Compare October 7, 2023 21:53
@jesstelford jesstelford force-pushed the responsive-props-not-use-breakpoint branch from 68a3864 to 731328a Compare October 19, 2023 20:32
Copy link
Contributor

Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant