Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v12-react-update-component-prop-color migration #10978

Open
wants to merge 5 commits into
base: update-component-prop-replacementmaps
Choose a base branch
from

Conversation

aaronccasanova
Copy link
Member

@aaronccasanova aaronccasanova commented Oct 12, 2023

This PR introduces a v12-react-update-component-prop-color migration that targets and updates a collection of Polaris component props using v11 color aliases.

Note: This is a companion to the v12-replace-custom-property-color migration and consumes it's replacement maps for consistency.

Example usage:

npx @shopify/polaris v12-react-update-component-prop-color --step=1 '**/*.{ts,tsx}'

@aaronccasanova aaronccasanova self-assigned this Oct 12, 2023
@aaronccasanova aaronccasanova marked this pull request as ready for review October 12, 2023 23:56
Copy link
Contributor

@sophschneider sophschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsies duplicate PR! They look pretty similar so Ill close mine out 🙇🏻‍♀️ #10979

@sophschneider
Copy link
Contributor

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @sophschneider! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20231013135949
yarn add @shopify/polaris@0.0.0-snapshot-release-20231013135949

@aaronccasanova
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20231013160735
yarn add @shopify/polaris@0.0.0-snapshot-release-20231013160735

Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨

Copy link
Contributor

Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants