Update metafield icon #11680
Merged
Update metafield icon #11680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran optimization and added changeset
Previous svg had uneven corners causing the icon to feel unbalanced.
heyjoethomas
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Hey @Rusty-UX . Thanks for throwing up the PR. I fixed the following to get all checks to pass and the final svg's to be 👍
- Added a changeset (required or build will fail). You can do this next by simply running
yarn changesetbefore submitting the PR. - Optimized the icons (this is a new required step). Do this by running
Yarn build && yarn optimizeinsidepolaris-icons. - The border radius on the top corners were not even so the icon wasn't symmetrical. Just evened it all out so it all looks 🤌 .
Thanks again for the contribution 🤝
Merged
|
@Rusty-UX make sure your changeset file is related to what this code does. In this case it should say "Update metafield icon design". |
sam-b-rose
pushed a commit
that referenced
this pull request
Mar 11, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@8.8.0 ### Minor Changes - [#11680](#11680) [`423ffb755`](423ffb7) Thanks [@Rusty-UX](https://github.com/Rusty-UX)! - Update metafield icon design ## @shopify/polaris@12.21.0 ### Minor Changes - [#11650](#11650) [`00e276407`](00e2764) Thanks [@kyledurand](https://github.com/kyledurand)! - Added `cover` as an `preferredPosition` to `Popover` - [#11696](#11696) [`6a1a5a6c4`](6a1a5a6) Thanks [@mmapplebeck](https://github.com/mmapplebeck)! - [Frame] Fixed regression that caused sidebar to render over Admin app content - [#11708](#11708) [`90a3cb1fb`](90a3cb1) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Increase icon size using viewBox for mobile screen sizes. This will enlarge icons on mobile without affecting the icon wrapper. ### Patch Changes - [#11689](#11689) [`da680f36a`](da680f3) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed touch device styling for removable large Tags - [#11693](#11693) [`3554a1004`](3554a10) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated BulkActionButton to render the Tooltip below the button, not above it - Updated dependencies \[[`423ffb755`](423ffb7)]: - @shopify/polaris-icons@8.8.0 ## polaris.shopify.com@0.65.0 ### Minor Changes - [#11703](#11703) [`add5ffbea`](add5ffb) Thanks [@lgriffee](https://github.com/lgriffee)! - Added shadow token design guidance ### Patch Changes - Updated dependencies \[[`423ffb755`](423ffb7), [`da680f36a`](da680f3), [`00e276407`](00e2764), [`3554a1004`](3554a10), [`6a1a5a6c4`](6a1a5a6), [`90a3cb1fb`](90a3cb1)]: - @shopify/polaris-icons@8.8.0 - @shopify/polaris@12.21.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
# Updating metafield icon design ### WHY are these changes introduced? Design updated to be have a bit more organic shapes, based on feedback ### Before / After @2x <img width="657" alt="render-test" src="https://github.com/Shopify/polaris/assets/4304867/741aa66d-4348-42e3-a9cf-3ecc99c44a87"> @1x  --------- Co-authored-by: Joe Thomas <joe.thomas@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating metafield icon design
WHY are these changes introduced?
Design updated to be have a bit more organic shapes, based on feedback
Before / After
@2x
@1x
