Reduce font size of helper, error, and footer text #11878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-b-rose
force-pushed
the
refine-component-text-sizes
branch
from
ca26af1
to
9fafb2f
Compare
|
/snapit |
|
🫰✨ Thanks @sam-b-rose! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris": "0.0.0-snapshot-20240411104329",
"polaris.shopify.com": "0.0.0-snapshot-20240411104329" |
Closed
sam-b-rose
changed the title
heyjoethomas
approved these changes
Apr 15, 2024
aaronccasanova
force-pushed
the
refine-component-text-sizes
branch
from
9fafb2f
to
73583fe
Compare
github-actions
bot
added
the
cla-needed
lgriffee
reviewed
May 2, 2024
Co-authored-by: Laura Griffee <laura@mailzone.com>
github-actions
bot
removed
the
cla-needed
lgriffee
changed the title
This was referenced May 6, 2024
aveline
approved these changes
May 6, 2024
lgriffee
approved these changes
May 6, 2024
|
closing duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-internal/issues/1567
The helper, error, and footer text are currently very large on mobile screens. This clashes with the native mobile styles when viewed on webviews.
WHAT is this pull request doing?
Bumping down the text size of the following components will help bring the text hierarchy closer to mobile.
📸 See Chromatic for all component diffs.
🌀 Spin link
Note
This is changing the text variation from
bodyMdtobodySm. However, Polaris Mobile uses mostlybodyMdpaired withbodyXs. We could consider also usingbodyXsor perhaps mobile could upshift tobodySm.Example screenshot
Example of mobile radio input
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes