-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Checkbox styling for mobile webview #11892
Update Checkbox styling for mobile webview #11892
Conversation
7a11e8f
to
bcdc37c
Compare
bcdc37c
to
1daed9b
Compare
Localization quality issues found The following issues may affect the quality of localized translations if they are not addressed:
Please look out for other instances of this issue in your PR and fix them as well if possible. Questions about these messages? Hop in the #help-localization Slack channel. |
1daed9b
to
2571926
Compare
1bbc4cc
to
3b506a6
Compare
3b506a6
to
383cc29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉🚢✨💯
'@shopify/polaris': minor | ||
--- | ||
|
||
Update `Checkbox` styling to improve mobile consistency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update `Checkbox` styling to improve mobile consistency | |
Updated `Checkbox` styling to improve mobile consistency |
@@ -211,7 +190,11 @@ export const Checkbox = forwardRef<CheckboxHandles, CheckboxProps>( | |||
!isIndeterminate && styles.animated, | |||
)} | |||
> | |||
{isIndeterminate ? <Icon source={MinusIcon} /> : iconSource} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By replacing this icon we are removing the checkbox icon animation that was added for the new design language, just wanted to confirm this is intentional @heyjoethomas?
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-internal/issues/1580
Fixes #33786
Caution
Basing this PR off of #11896 (which is also based off #11837) and will not merge until that ships.
Figma link
Update checkbox styling for mobile webviews
CheckIcon
18px
to20px
Unchecked
Checked
WHAT is this pull request doing?
How to 🎩
Tip
Make sure you have the breakpoint in storybook at
sm
orxs
to see the changesBefore Storybook
After Storybook
🎩 checklist
- [ ] Tested on mobile