Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO-NOT-MERGE/internal-only] AppCard components (Apps in Admin team) #11933

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryanschingeck
Copy link
Contributor

@ryanschingeck ryanschingeck commented Apr 23, 2024

WHY are these changes introduced?

https://github.com/Shopify/apps-in-admin/issues/2128

See component diagrams here: https://www.figma.com/file/Mv1OaVzpRn0uS23gE5EMTP/Shared-App-Card-UI-Diagrams?type=whiteboard&t=qc1SxVDzAEju4C08-0

Do not merge to @shopify/Polaris, team will be moving this to the internal-only repo soon

NOTE: I have not added docs/documentation yet, want to get feedback/review on overall structure first

Spin URL for Storybook demo: https://polaris.app-card-polaris.ryan-schingeck.us.spin.dev/?path=/story/all-components-appcardmetadata--no-description

Adds the following new components to Polaris to support our shared AppCard component:

  1. App Card
Screenshot 2024-04-24 at 3 36 10 PM
  1. AppCardAction
Screenshot 2024-04-24 at 3 36 26 PM
  1. AppCardBadge
Screenshot 2024-04-24 at 3 36 42 PM
  1. AppCardMetadata
Screenshot 2024-04-24 at 3 37 25 PM
  1. AppIcon
Screenshot 2024-04-24 at 3 37 41 PM
  1. SkeletonAppCard
Screenshot 2024-04-24 at 3 37 58 PM

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@ryanschingeck ryanschingeck self-assigned this Apr 23, 2024
@ryanschingeck ryanschingeck force-pushed the ryans/for-internal--appcard-component branch from 7c270d9 to aecc738 Compare April 24, 2024 19:33
@ryanschingeck
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @ryanschingeck! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240425162245"

@ryanschingeck
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @ryanschingeck! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240425165556"

@ryanschingeck ryanschingeck force-pushed the ryans/for-internal--appcard-component branch from d9443b8 to 4dc80e8 Compare April 25, 2024 20:28
@ryanschingeck
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @ryanschingeck! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/polaris-migrator": "0.0.0-snapshot-20240425204850",
"@shopify/polaris": "0.0.0-snapshot-20240425204850",
"@shopify/polaris-tokens": "0.0.0-snapshot-20240425204850",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240425204850"

@ryanschingeck
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @ryanschingeck! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/polaris-migrator": "0.0.0-snapshot-20240425212953",
"@shopify/polaris": "0.0.0-snapshot-20240425212953",
"@shopify/polaris-tokens": "0.0.0-snapshot-20240425212953",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240425212953"

@ryanschingeck ryanschingeck force-pushed the ryans/for-internal--appcard-component branch from 58bfe63 to c22cbbf Compare April 26, 2024 18:12
@ryanschingeck ryanschingeck force-pushed the ryans/for-internal--appcard-component branch from c22cbbf to b556d1e Compare April 26, 2024 18:13
@ryanschingeck
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @ryanschingeck! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/polaris-migrator": "0.0.0-snapshot-20240426182155",
"@shopify/polaris": "0.0.0-snapshot-20240426182155",
"@shopify/polaris-tokens": "0.0.0-snapshot-20240426182155",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240426182155"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant