Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Disabled text selection #11984

Closed
wants to merge 2 commits into from
Closed

[Mobile] Disabled text selection #11984

wants to merge 2 commits into from

Conversation

aveline
Copy link
Contributor

@aveline aveline commented May 6, 2024 •
edited
Loading

WHY are these changes introduced?

Resolves https://github.com/Shopify/mobile/issues/33793

WHAT is this pull request doing?

Disables text selection on small screens in order to be consistent with the behaviour on mobile.

How to 🎩

  • Go to storybook
  • Confirm text can be selected on a large screen
  • Confirm text cannot be selected on a small screen
Large screen Small screen
Screenshot 2024-05-06 at 10 31 50 AM Screenshot 2024-05-06 at 10 31 50 AM

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

lgriffee
lgriffee approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@lgriffee lgriffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎩✨🎉

@lgriffee lgriffee added the #gsd:40396 WebView infrastructure - Forms and Polaris label May 6, 2024
@aveline aveline marked this pull request as ready for review May 6, 2024 18:19
@aveline aveline closed this May 8, 2024
@aveline aveline deleted the mobile/disable-text-selection branch May 8, 2024 16:31
@aveline aveline restored the mobile/disable-text-selection branch May 8, 2024 16:34
@aveline aveline reopened this May 8, 2024
@aveline
Copy link
Contributor Author

aveline commented May 9, 2024

closing duplicate

@aveline aveline closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgriffee lgriffee lgriffee approved these changes

@davebcn87 davebcn87 Awaiting requested review from davebcn87

Assignees

@aveline aveline

Labels
#gsd:40396 WebView infrastructure - Forms and Polaris
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aveline @lgriffee