[Collapsible] Add transition delay #12118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @kyledurand! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240521154546" |
laurkim
approved these changes
May 21, 2024
polaris-react/src/components/Collapsible/Collapsible.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lo Kim <lo.kim@shopify.com>
kyledurand
force-pushed
the
collapsible_add-delay-prop
branch
from
fa00dcb
to
a0e0235
Compare
kyledurand
changed the title
sophschneider
approved these changes
May 21, 2024
kyledurand
force-pushed
the
collapsible_add-delay-prop
branch
from
9764968
to
405769d
Compare
Merged
laurkim
pushed a commit
that referenced
this pull request
Jun 3, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@13.5.0 ### Minor Changes - [#12118](#12118) [`5fcca651f`](5fcca65) Thanks [@kyledurand](https://github.com/kyledurand)! - Added transition delay to Collapsible ### Patch Changes - Updated dependencies \[[`fe2891792`](fe28917)]: - @shopify/polaris-icons@9.1.1 ## @shopify/polaris-icons@9.1.1 ### Patch Changes - [#12169](#12169) [`fe2891792`](fe28917) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Updated XIcon SVG path to correct size ## polaris.shopify.com@1.0.7 ### Patch Changes - [#12191](#12191) [`82f8a0dcd`](82f8a0d) Thanks [@sarahill](https://github.com/sarahill)! - Updated common action guidelines add example - [#12017](#12017) [`b54975aef`](b54975a) Thanks [@sarahill](https://github.com/sarahill)! - Updated common action pattern guidance for add actions - Updated dependencies \[[`5fcca651f`](5fcca65), [`fe2891792`](fe28917)]: - @shopify/polaris@13.5.0 - @shopify/polaris-icons@9.1.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of https://github.com/Shopify/polaris-internal/issues/159
WHAT is this pull request doing?
Adds a transition delay property. This will be useful while waiting for the search bar to animate out (top) before collapsing
Adds a style prop. Necessary for things like controlling width in a flex context. I'm not sure we need a full style prop, or classnames, or just try to limit it to flex grow / shrink. Open to ideas there. This is a pretty generic container so I don't think allowing a style prop is too bad.UPDATE: Opting to override in consumer css instead of adding a style prop here
🎩 checklist
README.mdwith documentation changes