Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EmptySpace] - Adding actionList props for primary and secondary actions to make Buttons work as Popovers #12190

Closed
wants to merge 1 commit into from

Conversation

aeperea
Copy link
Contributor

@aeperea aeperea commented May 30, 2024

WHY are these changes introduced?

App discovery in admin proposes to add dropdown options to the primary button for the EmptySpace component to add more functionality to the component. In order to allow this we propose adding a set of props actionList and secondaryActionList (the latter to add the same functionality to the secondaryAction button) of the type ActionListItemDescriptor[]. When the prop is present the button works as a Popover and which displays the actions under each of the primary and secondary buttons.

WHAT is this pull request doing?

Adding new props actionList and secondaryActionList. Defines a function that builds the markup depends on how the props are presented. Adding a new story to the storyboard and tests that verify that the right elements are being displayed with the provided props.

Screenshot 2024-05-30 at 07 53 26

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

馃帺 checklist

@aeperea
Copy link
Contributor Author

aeperea commented May 31, 2024

Close due to Polaris UX not approving the new design

@aeperea aeperea closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant