[AppProvider] Remove componentWillReceiveProps #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
force-pushed
the
ap-rm-cwrp
branch
from
2959584
to
49a9de1
Compare
Add test
AndrewMusgrave
force-pushed
the
ap-rm-cwrp
branch
from
49a9de1
to
3e5efd0
Compare
AndrewMusgrave
added
the
馃Skip Changelog
alex-page
reviewed
Apr 16, 2019
alex-page
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Remove deprecated lifecycle methods. This is in preparation for using the new context api.
WHAT is this pull request doing?
Storing context on state, getChildContext will be ran every time state changes and making use of componentDidUpdate.
How to 馃帺