Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testID warning #1447

Merged
merged 2 commits into from
May 15, 2019
Merged

Remove testID warning #1447

merged 2 commits into from
May 15, 2019

Conversation

AndrewMusgrave
Copy link
Member

@AndrewMusgrave AndrewMusgrave commented May 9, 2019

Fixes #1483

WHY are these changes introduced?

We're getting spammed with testID warnings

Screen Shot 2019-05-09 at 11 20 30 AM

WHAT is this pull request doing?

Fixing the regex to match the output

@BPScott BPScott temporarily deployed to polaris-react-pr-1447 May 9, 2019 15:23 Inactive
@AndrewMusgrave AndrewMusgrave added the 🤖Skip Changelog Causes CI to ignore changelog update check. label May 9, 2019
@AndrewMusgrave AndrewMusgrave merged commit 623cd1f into update-react May 15, 2019
@AndrewMusgrave AndrewMusgrave deleted the remove-testid-warning branch May 15, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants