[v4] Minor changes to bump test coverage slightly #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
commented
Aug 6, 2019
| @@ -308,6 +310,26 @@ describe('<DropZone />', () => { | |||
| const displayText = dropZone.find(DisplayText); | |||
| expect(displayText.contains(errorOverlayText)).toBe(true); | |||
| }); | |||
|
|
|||
| it('sets type from props on context', () => { | |||
There was a problem hiding this comment.
Test to make sure we're setting context
AndrewMusgrave
commented
Aug 6, 2019
| return; | ||
| } | ||
| this.skipToMainContentTargetNode.current.focus(); | ||
| this.skipToMainContentTargetNode.current && |
There was a problem hiding this comment.
skipToMainContentTargetNode will never be null after mount, this is just a shortcut and will give us coverage
AndrewMusgrave
commented
Aug 6, 2019
| @@ -56,7 +56,7 @@ export default function Icon({ | |||
| ); | |||
| } else if (source === 'placeholder') { | |||
| contentMarkup = <div className={styles.Placeholder} />; | |||
| } else if (typeof source === 'string') { | |||
| } else { | |||
There was a problem hiding this comment.
We don't need an if, elif, elif since we only have 3 type options (function, 'placeholder', string)
AndrewMusgrave
added
the
🤖Skip Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Bump test coverage 🎉