Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error log in tab test by adding _ref prop and forwardRef #1934

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

alex-page
Copy link
Member

@alex-page alex-page commented Aug 7, 2019

WHY are these changes introduced?

Fixes #1898

WHAT is this pull request doing?

Adds a ref so there is no error log during tests.

@alex-page alex-page self-assigned this Aug 7, 2019
@alex-page alex-page added this to the v4.0.0 milestone Aug 7, 2019
@BPScott BPScott temporarily deployed to polaris-react-pr-1934 August 7, 2019 14:15 Inactive
@alex-page alex-page added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Aug 7, 2019
Copy link
Member

@AndrewMusgrave AndrewMusgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ We should create an issue to add a focus method for Tabs to work correctly

@alex-page alex-page merged commit 6d5f138 into version-4.0.0 Aug 7, 2019
@alex-page alex-page deleted the remove-tab-error branch August 7, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants