[a11y]: Remove outline & border uses of ms-high-contrast #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginabak
added
the
Accessibility
ginabak
force-pushed
the
gbak-remove-mshighcontrast
branch
from
83a14f4
to
ee25049
Compare
ginabak
changed the title
ginabak
force-pushed
the
gbak-remove-mshighcontrast
branch
from
d16c331
to
e35fc51
Compare
ginabak
changed the title
alex-page
reviewed
Feb 9, 2021
alex-page
reviewed
Feb 9, 2021
alex-page
reviewed
Feb 9, 2021
alex-page
reviewed
Feb 9, 2021
sarahill
approved these changes
Feb 9, 2021
ginabak
force-pushed
the
gbak-remove-mshighcontrast
branch
from
16040d8
to
a366d61
Compare
alex-page
reviewed
Feb 12, 2021
ginabak
force-pushed
the
gbak-remove-mshighcontrast
branch
from
e621c82
to
4571684
Compare
alex-page
approved these changes
Feb 22, 2021
ginabak
force-pushed
the
gbak-remove-mshighcontrast
branch
from
ba10bb2
to
39e05ff
Compare
This was referenced Mar 18, 2021
sylvhama
pushed a commit
that referenced
this pull request
Mar 26, 2021
* Remove ms-high-contrast * Replace & tophat all non-mixin border/outline ms-high-contrast * Remove ActionList improvement for separate PR * Add outline & unreleased * Update UNRELEASED.md * Revert ActionList Changes * Remove border-top * Remove border-color in dualThumb * Add margin * Remove margin, add padding to ensure no mouse flicker * Border * Only render border in high-contrast mode * Temporary fix * Fix Unreleased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
(partly) Fixes #3826 : it only "partly" fixes the issue since this PR only removes the
outlineandborderuses of-ms-high-contrast.Inspired by this interesting article, which states that
basically does the same thing as
-ms-high-contrast: activeHOWEVER, 馃槶 it doesn鈥檛 work for firefox. See this article which talks about creating a custom media query called prefers-contrast, which is quite laborious. This is a temporary fix and will require thought as to how to account for firefox in high contrast mode.There are still many instances of
-ms-high-contrastin the Polaris repo.See here: https://github.com/search?q=%22-ms-high-contrast%22+repo%3AShopify%2Fpolaris-react&type=code
According MDN Web Docs:
More on the limitations of
-ms-high-contrast, here.WHAT is this pull request doing?
Summary of your gif(s)
note: the LEFT are the changes, the RIGHT is current production, there should be no visual changes in these, keep scrolling down for visual changes
Avatar
Banner
Contextual Save Bar
ProgressBar
Toast
Tag
Before & Afters (minor visual changes)
SingleThumb
DualThumb
(the changes are subtle, but before, there are 2 outlines, after there's only 1)
How to 馃帺
馃帺 checklist
README.mdwith documentation changes