Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move coverage into build/coverage #533

Merged
merged 1 commit into from Nov 3, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
@@ -1,6 +1,5 @@
node_modules
/build
/coverage
/build-intermediate
/build-esnext
/docs
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Expand Up @@ -4,7 +4,6 @@ node_modules
/build-intermediate
/build-esnext
/docs
/coverage
/esnext
/types
/index.*
Expand Down
1 change: 0 additions & 1 deletion .prettierignore
@@ -1,6 +1,5 @@
node_modules
/build
/coverage
/build-intermediate
/build-esnext
/docs
Expand Down
1 change: 0 additions & 1 deletion .stylelintignore
@@ -1,6 +1,5 @@
node_modules
/build
/coverage
/build-intermediate
/build-esnext
/docs
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -39,7 +39,7 @@
"check": "npm-run-all lint ts test",
"check:ci": "npm-run-all lint ts test:ci",
"clean": "rimraf build build-esnext esnext styles types docs 'build-intermediate' 'index.*' './src/styles/polaris-tokens' './tophat/.cache' './tophat/assets' 'styles.{css,scss}'",
"clean:build": "rimraf 'build/!(cache)' build-esnext esnext styles types docs 'build-intermediate' 'index.*' './src/styles/polaris-tokens' './tophat/.cache' './tophat/assets' 'styles.{css,scss}'",
"clean:build": "rimraf 'build/!(cache|coverage)' build-esnext esnext styles types docs 'build-intermediate' 'index.*' './src/styles/polaris-tokens' './tophat/.cache' './tophat/assets' 'styles.{css,scss}'",
"optimize": "node ./scripts/optimize.js",
"prebuild": "npm-run-all clean:build optimize copy-polaris-tokens",
"build": "babel-node ./scripts/build.js",
Expand Down
8 changes: 3 additions & 5 deletions sewing-kit.config.ts
Expand Up @@ -35,11 +35,9 @@ export default function sewingKitConfig(
};

// Code coverage
config.coverageDirectory = 'coverage';
config.coverageReporters = ['text-summary', 'html'];
if (env.isCI) {
config.coverageReporters.push('lcov');
}
config.coverageDirectory = 'build/coverage';
config.coverageReporters = ['text-summary', 'html', 'lcovonly'];

config.collectCoverageFrom = [
'src/**/*.{ts,tsx}',
'!src/test-utilities/**/*.*',
Expand Down