Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile update for choice list #5712

Merged
merged 42 commits into from
May 27, 2022
Merged

Mobile update for choice list #5712

merged 42 commits into from
May 27, 2022

Conversation

aveline
Copy link
Contributor

@aveline aveline commented May 4, 2022

WHY are these changes introduced?

Fixes #5443

What is this pull request doing?

  • Update styling of radio button on desktop and mobile
  • Increase size of radio button and checkbox on mobile only
  • Add spacing between ChoiceList items on mobile only

Screen Shot 2022-05-26 at 4 15 18 PM

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@aveline aveline marked this pull request as draft May 4, 2022 21:53
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

size-limit report 📦

Path Size
cjs 151.18 KB (+0.02% 🔺)
esm 87.53 KB (+0.03% 🔺)
esnext 138.5 KB (+0.08% 🔺)
css 37.84 KB (+0.18% 🔺)

@aveline aveline requested a review from alex-page May 6, 2022 18:25
@changeset-bot
Copy link

changeset-bot bot commented May 16, 2022

⚠️ No Changeset found

Latest commit: ff9f2c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aveline
Copy link
Contributor Author

aveline commented May 25, 2022

/snapshot-release

@github-actions
Copy link
Contributor

🤌 ✨ Thanks @aveline! Your snapshots have been shipped.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20220525214403
yarn add @shopify/polaris@0.0.0-snapshot-release-20220525214403
yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20220525214403
yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20220525214403

@aveline aveline marked this pull request as ready for review May 25, 2022 22:17
@aveline
Copy link
Contributor Author

aveline commented May 26, 2022

/snapshot-release

@github-actions
Copy link
Contributor

🫰✨ Thanks @aveline! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20220526211527
yarn add @shopify/polaris@0.0.0-snapshot-release-20220526211527
yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20220526211527
yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20220526211527

@aveline
Copy link
Contributor Author

aveline commented May 26, 2022

/snapshot-release

@github-actions
Copy link
Contributor

🫰✨ Thanks @aveline! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @shopify/polaris@0.0.0-snapshot-release-20220526222521

@aveline
Copy link
Contributor Author

aveline commented May 26, 2022

/snapshot-release

@github-actions
Copy link
Contributor

🫰✨ Thanks @aveline! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @shopify/polaris@0.0.0-snapshot-release-20220526230852

@aveline aveline merged commit 290b41c into main May 27, 2022
@aveline aveline deleted the mobile-choice-list branch May 27, 2022 18:24
@github-actions github-actions bot mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve polaris-react components for mobile webviews
3 participants