Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update experimental XL breakpoint value #5830

Merged
merged 4 commits into from
May 17, 2022

Conversation

aaronccasanova
Copy link
Member

@aaronccasanova aaronccasanova commented May 17, 2022

WHAT is this pull request doing?

This PR updates the xl breakpoint value to 1440px to enable equal widths for our 12 column grid:

Before:
((1400 - (32*2)) - (11 * 16)) / 12
96.67px each column

After:
((1440 - (32*2)) - (11 * 16)) / 12
100px each column

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

馃帺 checklist

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022

鈿狅笍 No Changeset found

Latest commit: a3ddac7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2022

size-limit report 馃摝

Path Size
cjs 150.78 KB (-0.01% 馃斀)
esm 86.91 KB (-0.01% 馃斀)
esnext 136.79 KB (-0.01% 馃斀)
css 37.23 KB (+0.01% 馃敽)

@aaronccasanova aaronccasanova merged commit 83b2791 into main May 17, 2022
@aaronccasanova aaronccasanova deleted the feat/update-experimental-xl-breakpoint branch May 17, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants