-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filters] Add disableQueryField
Property
#5832
Conversation
|
馃憢 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven鈥檛 already, please check out the contributing guidelines. |
size-limit report 馃摝
|
disableQueryField
PropertydisableQueryField
Property
9225555
to
6f3b69b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @Stivaros 馃憦
Co-Authored-By: Efstathios Stivaros <7734772+stivaros@users.noreply.github.com>
6f3b69b
to
6032e8b
Compare
Rebasing due to a merge conflict in |
We shipped a change yesterday which deleted UNRELEASED.md and now requires you to run |
Ah, thanks. Are you happy with the changes introduced in 27eac2d? |
That's perfect. Alex is taking the day off today so feel free to ship when 馃煝 I'm planning to cut a 9.9.0 release early next week as well |
@kyledurand there's a pending change in the UI Tests check which requires manual intervention. Is that my remit or yours? It's as I expect - the query field is disabled in the screenshot. |
I believe I approved that when I reviewed but you have to manually approve them on every new push. I marked it approved 馃憤 |
馃帀 Thanks for your contribution to Polaris! |
WHY are these changes introduced?
The
disable
property allows a developer to disable the entire component and thehideQueryField
property enables a developer to hide the query field. Prior to this PR, there was no first-class way to disable the query field.Hiding and showing a field can be a bit of a UX nightmare but sometimes we don't want users to be performing text searches.
WHAT is this pull request doing?
It adds a
disableQueryField
property to theFilters
component which will disable theTextField
(aka "query field") when set totrue
. Please see below video for a demo in the browser.`disableQueryField` Demo Video
https://user-images.githubusercontent.com/7734772/169001146-d3cc1e17-5672-4232-9c3c-9470a88340bc.mp4How to 馃帺
Add
disableQueryFilter={true}
(orfalse
) to any<Filters>
component馃帺 checklist
README.md
with documentation changes