Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Improves styling on hidden ClearButton in TextField component. #5889

Merged
merged 1 commit into from
May 26, 2022

Conversation

zaquille-oneil
Copy link
Contributor

WHY are these changes introduced?

Fixes #5888. Screenshots are shown in the github issue.

WHAT is this pull request doing?

Renaming and adjusting a CSS style on the TextField component.

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

馃帺 checklist

@ghost
Copy link

ghost commented May 23, 2022

馃憢 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven鈥檛 already, please check out the contributing guidelines.

@zaquille-oneil zaquille-oneil force-pushed the ZL/add-display-none-for-text-field branch from f457441 to fa32bb0 Compare May 23, 2022 18:47
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022

size-limit report 馃摝

Path Size
cjs 150.17 KB (-0.02% 馃斀)
esm 86.56 KB (-0.02% 馃斀)
esnext 136.52 KB (-0.03% 馃斀)
css 37.3 KB (-0.02% 馃斀)

Copy link
Member

@chloerice chloerice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this @zaquille-oneil!! 馃帀 I think we can do away with the CSS altogether, but I'm having trouble running Storybook so I haven't tophatted my suggestion.

.changeset/strange-scissors-poke.md Outdated Show resolved Hide resolved
polaris-react/src/components/TextField/TextField.scss Outdated Show resolved Hide resolved
polaris-react/src/components/TextField/TextField.tsx Outdated Show resolved Hide resolved
polaris-react/src/components/TextField/TextField.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@stefanlegg stefanlegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm fine with either the current approach or the one @chloerice suggested 馃憤

@zaquille-oneil
Copy link
Contributor Author

Thanks for catching and fixing this @zaquille-oneil!! 馃帀 I think we can do away with the CSS altogether, but I'm having trouble running Storybook so I haven't tophatted my suggestion.

np! glad I could help. I've implemented your suggestion and ran storybook with it. things work just fine when hiding the clear button

@zaquille-oneil zaquille-oneil force-pushed the ZL/add-display-none-for-text-field branch from fa32bb0 to 6ff1bda Compare May 25, 2022 21:37
@zaquille-oneil zaquille-oneil merged commit fe89879 into main May 26, 2022
@zaquille-oneil zaquille-oneil deleted the ZL/add-display-none-for-text-field branch May 26, 2022 16:06
@ghost
Copy link

ghost commented May 26, 2022

馃帀 Thanks for your contribution to Polaris!

@github-actions github-actions bot mentioned this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TextField] change properties on ClearButton in TextField to improve visibility in mobile
3 participants