-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField] Improves styling on hidden ClearButton in TextField component. #5889
Conversation
馃憢 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven鈥檛 already, please check out the contributing guidelines. |
f457441
to
fa32bb0
Compare
size-limit report 馃摝
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching and fixing this @zaquille-oneil!! 馃帀 I think we can do away with the CSS altogether, but I'm having trouble running Storybook so I haven't tophatted my suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm fine with either the current approach or the one @chloerice suggested 馃憤
np! glad I could help. I've implemented your suggestion and ran storybook with it. things work just fine when hiding the clear button |
fa32bb0
to
6ff1bda
Compare
馃帀 Thanks for your contribution to Polaris! |
WHY are these changes introduced?
Fixes #5888. Screenshots are shown in the github issue.
WHAT is this pull request doing?
Renaming and adjusting a CSS style on the TextField component.
How to 馃帺
馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:馃帺 checklist
README.md
with documentation changes