Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Grid component #5945

Merged
merged 4 commits into from
May 25, 2022
Merged

feat: Add Grid component #5945

merged 4 commits into from
May 25, 2022

Conversation

aaronccasanova
Copy link
Member

@aaronccasanova aaronccasanova commented May 25, 2022

WHAT is this pull request doing?

This PR re-introduces the Grid component and updates the implementation to use the JSON token groups in polaris-react/src/tokens.

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

size-limit report 📦

Path Size
cjs 151.07 KB (+0.59% 🔺)
esm 87.43 KB (+1% 🔺)
esnext 138.31 KB (+1.29% 🔺)
css 37.77 KB (+1.24% 🔺)

@aaronccasanova
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

🤌 ✨ Thanks @aaronccasanova! Your snapshots have been shipped.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20220525203542
yarn add @shopify/polaris@0.0.0-snapshot-release-20220525203542
yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20220525203542
yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20220525203542

Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Tophatted using polaris snapshot in a spin instance and confirmed there weren't any errors re: breakpoints 👍

@aaronccasanova
Copy link
Member Author

Wow thanks @laurkim! Will you review all my PRs ❤️

@aaronccasanova aaronccasanova merged commit 54d15c3 into main May 25, 2022
@aaronccasanova aaronccasanova deleted the feat/add-grid-component branch May 25, 2022 22:50
@github-actions github-actions bot mentioned this pull request May 25, 2022
@aaronccasanova
Copy link
Member Author

/snapit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants