-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Grid component #5945
feat: Add Grid component #5945
Conversation
size-limit report 📦
|
/snapit |
🤌 ✨ Thanks @aaronccasanova! Your snapshots have been shipped. Test the snapshots by updating your yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20220525203542 yarn add @shopify/polaris@0.0.0-snapshot-release-20220525203542 yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20220525203542 yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20220525203542 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Tophatted using polaris
snapshot in a spin instance and confirmed there weren't any errors re: breakpoints 👍
Wow thanks @laurkim! Will you review all my PRs ❤️ |
/snapit |
WHAT is this pull request doing?
This PR re-introduces the
Grid
component and updates the implementation to use the JSON token groups inpolaris-react/src/tokens
.