Loom clean up #5960
Merged
Loom clean up #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Ben Scott <227292+BPScott@users.noreply.github.com>
size-limit report 📦
|
Co-Authored-By: Ben Scott <227292+BPScott@users.noreply.github.com>
alex-page
commented
May 27, 2022
alex-page
commented
May 27, 2022
|
We did this as a first step to removing loom as I wasn't sure how far we'd get. Turns out we got pretty dang far. I'm tempted to say we close this, and keep all the "delete loom" stuff in #5960 |
|
I agree Ben! Going to merge it anyway and start hacking on the other PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Ben Scott 227292+BPScott@users.noreply.github.com