[TextField] Add the event argument to the onBlur prop
#6143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloerice
force-pushed
the
fix-textfield-onblur
branch
2 times, most recently
from
092ab74
to
8756c99
Compare
melnikov-s
reviewed
Jun 15, 2022
| onFocus?: (event?: React.FocusEvent<HTMLElement>) => void; | ||
| /** Callback fired when focus is removed */ | ||
| onBlur?(): void; | ||
| onFocus?: (event?: React.FocusEvent) => void; |
There was a problem hiding this comment.
I know it's not technically part of this PR but wondering why the onFocus has a optional event in the parameters. Shouldn't it always be there?
There was a problem hiding this comment.
Huh, good call I'm not sure 🤔
chloerice
force-pushed
the
fix-textfield-onblur
branch
from
8756c99
to
10f1b19
Compare
chloerice
force-pushed
the
fix-textfield-onblur
branch
from
10f1b19
to
151f9a5
Compare
size-limit report 📦
|
Germanika
approved these changes
Jun 15, 2022
Merged
6 tasks
chloerice
added a commit
that referenced
this pull request
Jun 17, 2022
…#6224) * [TextField] Reverts onFocus event arg not being optional * [TextField] Make onBlur event optional
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #6115
WHAT is this pull request doing?
Callbacks set on the
TextFieldonBlurprop had to hack around the lack of support for theeventargument passed implicitly by theinputprior to shipping #5957. This PR fixes regressions upstream inwebby adding and passing theeventargument to theonBlurprop so that consuming apps don't need to hack their callback's types when composing complex inputs likeDatePickerTextField.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes