-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stylelint-polaris/media-queries-allowed-list plugin #6438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the screenshot, I see the output as errors and I think these should be warnings. We want to encourage consistency and push towards the Polaris values. Once there is a high level of adoption these can become errors. I might be reading this wrong though!
@alex-page Good call! I set the internal config to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢✨🎉
Added a last minute update to the |
WHAT is this pull request doing?
This PR introduces a new
stylelint-polaris/media-queries-allowed-list
plugin to ensure@media
rules only use the new Polarisbreakpoints
aliases and other support media types.e.g.
stylelint **/*.scss
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes