Clean up readme files #6703
Merged
Clean up readme files #6703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
commented
Jul 21, 2022
Comment on lines
-223
to
-230
| When the `error` prop has a boolean value of `true`, the select component indicates to merchants that their input is invalid without rendering an error message directly below it. It anticipates that an inline error component exists separately within the form. | ||
|
|
||
| To render an invalid select and its validation error separately: | ||
|
|
||
| - Set a unique identifier to the select component `id` prop | ||
| - Set a boolean to the select component `error` prop | ||
| - Use an [inline error component](https://polaris.shopify.com/components/inline-error) to describe the invalid select input and set its `fieldID` prop to the same unique identifier used for the text field `id` | ||
|
|
There was a problem hiding this comment.
This isn't used on the new site and is quite detailed information. I am going to remove for now.
size-limit report 📦
|
|
cc @martenbjork for visibility, have to merge a couple of these to stay unblocked. Let me know if you spot any issues. |
Merged
27 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When automating bringing across example titles a bunch of changes were noticed. This cleans them up for automation.