Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook version bump and clean up #6792

Merged
merged 8 commits into from
Jul 28, 2022

Conversation

alex-page
Copy link
Member

@alex-page alex-page commented Jul 27, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

size-limit report 📦

Path Size
polaris-react-cjs 198.39 KB (0%)
polaris-react-esm 133.15 KB (0%)
polaris-react-esnext 188.35 KB (0%)
polaris-react-css 41.79 KB (0%)

@kyledurand kyledurand changed the title Storybook version bump and clean up Revert Storybook version bump and clean up Jul 27, 2022
@kyledurand kyledurand changed the title Revert Storybook version bump and clean up Storybook version bump and clean up Jul 27, 2022
@alex-page alex-page force-pushed the revert-6791-revert-storybook-change branch from 0604510 to 4cb6900 Compare July 27, 2022 23:16
.changeset/green-trees-beam.md Outdated Show resolved Hide resolved
Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can successfully run yarn && yarn build and storybook/styleguide locally 🚀 💯

Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
@@ -41,7 +41,7 @@
"@types/marked": "^4.0.3",
"@types/node": "17.0.21",
"@types/prismjs": "^1.26.0",
"@types/react": "17.0.39",
"@types/react": "*",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site cannot resolve the types without the "*"

@alex-page alex-page merged commit 51be08e into main Jul 28, 2022
@alex-page alex-page deleted the revert-6791-revert-storybook-change branch July 28, 2022 15:51
@github-actions github-actions bot mentioned this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants